Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: website and headline #691

Merged
merged 8 commits into from
Apr 24, 2024
Merged

fix: website and headline #691

merged 8 commits into from
Apr 24, 2024

Conversation

zifeo
Copy link
Member

@zifeo zifeo commented Apr 23, 2024

Motivation and context

Fix the CSS issue introduced by docusaurus 3.2.0 (facebook/docusaurus#10005). 3.2.1 should fix it but the affected version maybe loaded by dependencies, so we will have to wait a bit more.

Checklist

  • The change come with new or modified tests
  • Hard-to-understand functions have explanatory comments
  • End-user documentation is updated to reflect the change

Copy link

codecov bot commented Apr 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.91%. Comparing base (4db7dc7) to head (8d572b3).

❗ Current head 8d572b3 differs from pull request most recent head 7fe9433. Consider uploading reports for the commit 7fe9433 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #691   +/-   ##
=======================================
  Coverage   75.91%   75.91%           
=======================================
  Files         120      120           
  Lines       13517    13517           
  Branches     1415     1415           
=======================================
  Hits        10262    10262           
  Misses       3233     3233           
  Partials       22       22           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Natoandro
Natoandro previously approved these changes Apr 24, 2024
michael-0acf4
michael-0acf4 previously approved these changes Apr 24, 2024
@michael-0acf4
Copy link
Contributor

Side note:

On #685, I have this issue on proposition_test.ts

Caused by:
    0: failed to unpack `package/gen/typegraph_core.core.wasm` into `/runner/_work/metatype/metatype/deno-dir/npm/localhost_4873/@typegraph/sdk/0.3.7-0/gen/typegraph_core.core.wasm`
    1: File exists (os error 17)
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

And this on wasm_test.ts (same as the one failing on this PR)

./typegate/tests/runtimes/wasm/wasm_test.ts (uncaught error)
error: (in promise) CompileError: WebAssembly.compile(): section (code 0, "Unknown") extends past end of the module (length 14483253, remaining bytes 4623799) @+4591177
    at fetchCompile (file:///runner/_work/metatype/metatype/deno-dir/npm/localhost_4873/@typegraph/sdk/0.3.7-0/gen/typegraph_core.js:21:24)
    at eventLoopTick (ext:core/01_core.js:153:7)
    at async file:///runner/_work/metatype/metatype/deno-dir/npm/localhost_4873/@typegraph/sdk/0.3.7-0/gen/typegraph_core.js:6276:50
    at async file:///runner/_work/metatype/metatype/deno-dir/npm/localhost_4873/@typegraph/sdk/0.3.7-0/gen/typegraph_core.js:6309:1
This error was not caught from a test and caused the test runner to fail on the referenced module.
It most likely originated from a dangling promise, event/timeout handler or top-level code.

which I believe all came from node sdk import.

@Natoandro Natoandro dismissed stale reviews from michael-0acf4 and themself via 8d572b3 April 24, 2024 13:22
@zifeo zifeo merged commit d2e691f into main Apr 24, 2024
9 of 10 checks passed
@zifeo zifeo deleted the web branch April 24, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants