Fix (setf gethash) in the fallback solution not returning the new value

It would return nil.
metawilm · Nov 19, 2020 · 7bd02a5 · 7bd02a5
1 parent f269831
commit 7bd02a5
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/custom-hash-table.lisp b/custom-hash-table.lisp
@@ -115,8 +115,10 @@ Offending form: ~S" loop-form))))
                          (loop for x-and-val in existing-values
                              for (x-key . nil) = x-and-val
                              when (funcall test-fn key x-key)
-                             do (progn (setf (cdr x-and-val) new-val) (return-from gethash))
-                             finally (push (cons key new-val) (gethash key.hash real-ht)))))))
+                             do (progn (setf (cdr x-and-val) new-val)
+                                       (return-from gethash new-val))
+                             finally (push (cons key new-val) (gethash key.hash real-ht))
+                                     (return new-val))))))
 
 (defun remhash (key ht)
   (etypecase ht