fix: add check if msg and meta properties are deleted and give priority to log.meta in meta object #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think is not necessary to do such checks but I agree we can do a fast check before deleting the property as can reduce unnecessary burden 👍 About the coverage is ok if it drops but we should always aim to keep it around ~90% 👍 |
metcoder95
reviewed
Sep 18, 2022
kruczyna
changed the title
metcoder95
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a check to make sure the msg and meta properties are deleted. Did not
returnas it's not a business critical issue. Also, the coverage dropped to 91%, did not cover those lines with unit tests yet. Is this something desired, though? I am not sure about that TBH 😅Context:
If we don't delete it will end with a duplicated messge, something like
msg: 'I am a message'andmessage: 'I am a message. If we do not delete the meta property we'll not have more custom meta in the LogEntry.