This repository has been archived by the owner on Oct 2, 2021. It is now read-only.
Fix source map generation #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes source map generation to resolve one of the debugging issues described in meteor/meteor#8611.
The source maps that are generated by
compileare wrong if at least one Babel plugin is included in theoptionsobject (see meteor/meteor#8611 (comment)). I'm not really sure why the current implementation doesn't work but it looks like it's a problem with Babel'sinputSourceMapoption. Instead of using an intermediate source map, I think it's fine to transform the AST twice and let Babel generate the source map from the final AST only. Another benefit is thatcompiledoesn't have to generate code twice (once for each pass) anymore.I have tested this change with a few combinations of Babel plugins and presets and
compilealways created a correct source map.