Skip to content
This repository has been archived by the owner on Oct 24, 2021. It is now read-only.

Hides brackets when no option type is present #71

Closed
wants to merge 1 commit into from
Closed

Hides brackets when no option type is present #71

wants to merge 1 commit into from

Conversation

tarunbatra
Copy link
Contributor

No description provided.

@lorensr
Copy link
Contributor

lorensr commented Jul 21, 2016

Hey Tarun, noticed a problem with http://docs.meteor.com/api/templates.html

Here is current master:

image

Here is your branch:

image

@lorensr
Copy link
Contributor

lorensr commented Jul 21, 2016

Stylistically, I think lighter color & italics might be a better solution than brackets. Like "String" here:

image

To me brackets means optional, like in man pages:

image

cc @dominicnguyen

@domyen
Copy link

domyen commented Jul 22, 2016

Agree with @lorensr on the styling. Change lgtm otherwise.

@tarunbatra
Copy link
Contributor Author

yeah @lorensr, even i think its better to be consistent in docs.

@lorensr
Copy link
Contributor

lorensr commented Jul 22, 2016

Done: meteor/meteor-theme-hexo#20

@lorensr lorensr closed this Jul 22, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants