Allow smtps:// in MAIL_URL to enable secureConnection #7043
Conversation
|
@MichaelJCole: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/ |
MichaelJCole
changed the title
|
Please see #7042 |
MichaelJCole
changed the title
MichaelJCole
changed the title
| throw new Error("Email protocol in $MAIL_URL (" + | ||
| mailUrlString + ") must be 'smtp'"); | ||
| mailUrlString + ") must be 'smtp' or 'smtps'"); |
There was a problem hiding this comment.
This only changes whether or not an error is thrown when smtps is used. It doesn't change secureConnection below.
|
This doesn't appear to change the |
|
You had this code in the Issue ...but it's not here in the PR. This makes the difference between this change working and not working by allowing the additional trigger for Pretty strange for SparkPost to just not support it though. I'm aware it is not RFC and it's silly, but it is widely accepted by many (Gmail, Hotmail, Mandrill, SendGrid, MailGun, AWS SES, etc.). Looks like Postmarkapp doesn't support it either. Want to update this PR? |
abernix
changed the title
|
@abernix Hey Jesse, there are steps in git, and I missed one. Pushed the 2nd commit. Good catch. Yeah, this PR didn't fix the SparkPost issue. I'm in a hurry and switched to Mailgun instead. the 'simpleSMTP' npm package is depricated. Next steps for Sparkpost issue would be to switch to a new mail transport library, but that's a bigger choice than a drive-by PR :-) |
|
@MichaelJCole, thanks for this leg work. I'm experiencing this as well with Sparkpost. Do I understand correctly then that there's no known fix for Sparkpost? Enabling |
|
Hey @carinakoo I was in a hurry and switched to mailgun with no problems yet. You might get a better response from Sparkpost because you're not the first. Give their support a try. secureConnection did not solve it for me. |
|
Looks great, thanks everyone! |
This backwards compatible patch allows smtps protocol, and secureConnection on port 587. Port 465 is non-standard and assigned to something else. See #7042 for details.