Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Allow smtps:// in MAIL_URL to enable secureConnection #7043
changed the title from
Allow smtps protocol. Use standard port 587. Port 465 was never standard for secure email.
Allow smtps protocol. Use standard port 587. Port 465 was never standard for secure smtp.
May 12, 2016
You had this code in the Issue
...but it's not here in the PR. This makes the difference between this change working and not working by allowing the additional trigger for
Pretty strange for SparkPost to just not support it though. I'm aware it is not RFC and it's silly, but it is widely accepted by many (Gmail, Hotmail, Mandrill, SendGrid, MailGun, AWS SES, etc.). Looks like Postmarkapp doesn't support it either.
Want to update this PR?
@abernix Hey Jesse, there are steps in git, and I missed one. Pushed the 2nd commit. Good catch.
Yeah, this PR didn't fix the SparkPost issue. I'm in a hurry and switched to Mailgun instead. the 'simpleSMTP' npm package is depricated. Next steps for Sparkpost issue would be to switch to a new mail transport library, but that's a bigger choice than a drive-by PR :-)