Release 1.4.2.2 (and 1.4.2.3)

Contributing.md

@@ -230,7 +230,7 @@ these guidelines:
  * Include tests that prove your code works.
 
  * Follow the
-   [MDG style guide](https://github.com/meteor/meteor/wiki/Meteor-Style-Guide)
+   [MDG style guide](https://guide.meteor.com/code-style.html#javascript)
    for code and commit messages.
 
  * Be sure your author field in git is properly filled out with your full name

History.md

@@ -1,5 +1,50 @@
 ## v.NEXT
 
+## v1.4.2.3
+
+* Style improvements for `meteor create --full`.
+  [#8045](https://github.com/meteor/meteor/pull/8045)
+
+> Note: Meteor 1.4.2.2 was finalized before
+  [#8045](https://github.com/meteor/meteor/pull/8045) was merged, but
+  those changes were [deemed important
+  enough](https://github.com/meteor/meteor/pull/8044#issuecomment-260913739)
+  to skip recommending 1.4.2.2 and instead immediately release 1.4.2.3.
+
+## v1.4.2.2
+
+* Node has been upgraded to version 4.6.2.
+
+* `meteor create` now has a new `--full` option, which generates an larger app,
+  demonstrating development techniques highlighted in the
+  [Meteor Guide](http://guide.meteor.com)
+
+  [Issue #6974](https://github.com/meteor/meteor/issues/6974)
+  [PR #7807](https://github.com/meteor/meteor/pull/7807)
+
+* Minimongo now supports `$min`, `$max` and partially supports `$currentDate`.
+  [Issue #7857](https://github.com/meteor/meteor/issues/7857)
+  [PR #7858](https://github.com/meteor/meteor/pull/7858)
+
+* Fix for [Issue #5676](https://github.com/meteor/meteor/issues/5676)
+  [PR #7968](https://github.com/meteor/meteor/pull/7968)
+
+* It is now possible for packages to specify a *lazy* main module:
+  ```js
+  Package.onUse(function (api) {
+    api.mainModule("client.js", "client", { lazy: true });
+  });
+  ```
+  This means the `client.js` module will not be evaluated during app
+  startup unless/until another module imports it, and will not even be
+  included in the client bundle if no importing code is found. **Note 1:**
+  packages with lazy main modules cannot use `api.export` to export global
+  symbols to other packages/apps. **Note 2:** packages with lazy main
+  modules should be restricted to Meteor 1.4.2.2 or later via
+  `api.versionsFrom("1.4.2.2")`, since older versions of Meteor cannot
+  import lazy main modules using `import "meteor/<package name>"` but must
+  explicitly name the module: `import "meteor/<package name>/client.js"`.
+
 ## v1.4.2.1
 
 * Installing the `babel-runtime` npm package in your application

meteor

@@ -1,6 +1,6 @@
 #!/usr/bin/env bash
 
-BUNDLE_VERSION=4.6.2
+BUNDLE_VERSION=4.7.1
 
 # OS Check. Put here because here is where we download the precompiled
 # bundles that are arch specific.

packages/accounts-password/package.js

@@ -1,6 +1,6 @@
 Package.describe({
   summary: "Password support for accounts",
-  version: "1.3.2"
+  version: "1.3.3"
 });
 
 Package.onUse(function(api) {

packages/accounts-password/password_client.js

@@ -220,7 +220,12 @@ Accounts.forgotPassword = function(options, callback) {
   if (!options.email) {
     return reportError(new Meteor.Error(400, "Must pass options.email"), callback);
   }
-  Accounts.connection.call("forgotPassword", options, callback);
+
+  if (callback) {
+    Accounts.connection.call("forgotPassword", options, callback);
+  } else {
+    Accounts.connection.call("forgotPassword", options);
+  }
 };
 
 // Resets a password based on a token originally created by

packages/accounts-password/password_tests.js

@@ -2,7 +2,7 @@ Accounts._noConnectionCloseDelayForTest = true;
 
 if (Meteor.isServer) {
   Accounts.removeDefaultRateLimit();
-  
+
   Meteor.methods({
     getResetToken: function () {
       var token = Meteor.users.findOne(this.userId).services.password.reset;
@@ -557,8 +557,8 @@ if (Meteor.isClient) (function () {
       }, 10 * 1000, 100);
     }
   ]);
-  
-  
+
+
   testAsyncMulti("passwords - forgotPassword client return error when empty email", [
     function (test, expect) {
       // setup
@@ -578,7 +578,36 @@ if (Meteor.isClient) (function () {
       }, /Must pass options\.email/);
     },
   ]);
-
+
+  Tinytest.add(
+    'passwords - forgotPassword only passes callback value to forgotPassword '
+    + 'Method if callback is defined (to address issue #5676)',
+    function (test) {
+      let methodCallArgumentCount = 0;
+      const originalMethodCall = Accounts.connection.call;
+      const stubMethodCall = (...args) => {
+        methodCallArgumentCount = args.length;
+      }
+      Accounts.connection.call = stubMethodCall;
+
+      Accounts.forgotPassword({ email: 'test@meteor.com' });
+      test.equal(
+        methodCallArgumentCount,
+        2,
+        'Method call should have 2 arguments since no callback is passed in'
+      );
+
+      Accounts.forgotPassword({ email: 'test@meteor.com' }, () => {});
+      test.equal(
+        methodCallArgumentCount,
+        3,
+        'Method call should have 3 arguments since a callback is passed in'
+      );
+
+      Accounts.connection.call = originalMethodCall;
+    }
+  );
+
   testAsyncMulti("passwords - verifyEmail client return error when empty token", [
     function (test, expect) {
       // setup
@@ -598,7 +627,7 @@ if (Meteor.isClient) (function () {
       }, /Need to pass token/);
     },
   ]);
- 
+
   testAsyncMulti("passwords - resetPassword errors", [
     function (test, expect) {
       // setup

packages/babel-runtime/package.js

@@ -1,7 +1,7 @@
 Package.describe({
   name: "babel-runtime",
   summary: "Runtime support for output of Babel transpiler",
-  version: '1.0.0',
+  version: '1.0.1',
   documentation: 'README.md'
 });
 

packages/coffeescript/package.js

@@ -1,6 +1,6 @@
 Package.describe({
   summary: "Javascript dialect with fewer braces and semicolons",
-  version: "1.11.1_3"
+  version: "1.11.1_4"
 });
 
 Package.registerBuildPlugin({

packages/ecmascript/package.js

@@ -1,6 +1,6 @@
 Package.describe({
   name: 'ecmascript',
-  version: '0.6.0',
+  version: '0.6.1',
   summary: 'Compiler plugin that supports ES2015+ in all .js files',
   documentation: 'README.md'
 });

packages/less/package.js

@@ -1,6 +1,6 @@
 Package.describe({
   name: 'less',
-  version: '2.7.7',
+  version: '2.7.8',
   summary: 'Leaner CSS language',
   documentation: 'README.md'
 });

packages/meteor-tool/package.js

@@ -1,6 +1,6 @@
 Package.describe({
   summary: "The Meteor command-line tool",
-  version: '1.4.2_1'
+  version: '1.4.2_3'
 });
 
 Package.includeTool();

packages/minimongo/minimongo_tests.js

@@ -2086,7 +2086,12 @@ Tinytest.add("minimongo - modify", function (test) {
     coll.update(query, mod);
     var actual = coll.findOne();
     delete actual._id;  // added by insert
-    test.equal(actual, expected, EJSON.stringify({input: doc, mod: mod}));
+
+    if (typeof expected === "function") {
+      expected(actual, EJSON.stringify({input: doc, mod: mod}));
+    } else {
+      test.equal(actual, expected, EJSON.stringify({input: doc, mod: mod}));
+    }
   };
   var modify = function (doc, mod, expected) {
     modifyWithQuery(doc, {}, mod, expected);
@@ -2235,6 +2240,53 @@ Tinytest.add("minimongo - modify", function (test) {
   modify({a: {b: 2}}, {$inc: {'a.c': 10}}, {a: {b: 2, c: 10}});
   exception({}, {$inc: {_id: 1}});
 
+  // $currentDate
+  modify({}, {$currentDate: {a: true}}, (result, msg) => { test.instanceOf(result.a,Date,msg) });
+  modify({}, {$currentDate: {a: {$type: "date"}}}, (result, msg) => { test.instanceOf(result.a,Date,msg) });
+  exception({}, {$currentDate: {a: false}});
+  exception({}, {$currentDate: {a: {}}});
+  exception({}, {$currentDate: {a: {$type: "timestamp"}}});
+
+  // $min
+  modify({a: 1, b: 2}, {$min: {b: 1}}, {a: 1, b: 1});
+  modify({a: 1, b: 2}, {$min: {b: 3}}, {a: 1, b: 2});
+  modify({a: 1, b: 2}, {$min: {c: 10}}, {a: 1, b: 2, c: 10});
+  exception({a: 1}, {$min: {a: '10'}});
+  exception({a: 1}, {$min: {a: true}});
+  exception({a: 1}, {$min: {a: [10]}});
+  exception({a: '1'}, {$min: {a: 10}});
+  exception({a: [1]}, {$min: {a: 10}});
+  exception({a: {}}, {$min: {a: 10}});
+  exception({a: false}, {$min: {a: 10}});
+  exception({a: null}, {$min: {a: 10}});
+  modify({a: [1, 2]}, {$min: {'a.1': 1}}, {a: [1, 1]});
+  modify({a: [1, 2]}, {$min: {'a.1': 3}}, {a: [1, 2]});
+  modify({a: [1, 2]}, {$min: {'a.2': 10}}, {a: [1, 2, 10]});
+  modify({a: [1, 2]}, {$min: {'a.3': 10}}, {a: [1, 2, null, 10]});
+  modify({a: {b: 2}}, {$min: {'a.b': 1}}, {a: {b: 1}});
+  modify({a: {b: 2}}, {$min: {'a.c': 10}}, {a: {b: 2, c: 10}});
+  exception({}, {$min: {_id: 1}});
+
+  // $max
+  modify({a: 1, b: 2}, {$max: {b: 1}}, {a: 1, b: 2});
+  modify({a: 1, b: 2}, {$max: {b: 3}}, {a: 1, b: 3});
+  modify({a: 1, b: 2}, {$max: {c: 10}}, {a: 1, b: 2, c: 10});
+  exception({a: 1}, {$max: {a: '10'}});
+  exception({a: 1}, {$max: {a: true}});
+  exception({a: 1}, {$max: {a: [10]}});
+  exception({a: '1'}, {$max: {a: 10}});
+  exception({a: [1]}, {$max: {a: 10}});
+  exception({a: {}}, {$max: {a: 10}});
+  exception({a: false}, {$max: {a: 10}});
+  exception({a: null}, {$max: {a: 10}});
+  modify({a: [1, 2]}, {$max: {'a.1': 3}}, {a: [1, 3]});
+  modify({a: [1, 2]}, {$max: {'a.1': 1}}, {a: [1, 2]});
+  modify({a: [1, 2]}, {$max: {'a.2': 10}}, {a: [1, 2, 10]});
+  modify({a: [1, 2]}, {$max: {'a.3': 10}}, {a: [1, 2, null, 10]});
+  modify({a: {b: 2}}, {$max: {'a.b': 3}}, {a: {b: 3}});
+  modify({a: {b: 2}}, {$max: {'a.c': 10}}, {a: {b: 2, c: 10}});
+  exception({}, {$max: {_id: 1}});
+
   // $set
   modify({a: 1, b: 2}, {$set: {a: 10}}, {a: 10, b: 2});
   modify({a: 1, b: 2}, {$set: {c: 10}}, {a: 1, b: 2, c: 10});

packages/minimongo/modify.js

@@ -182,6 +182,46 @@ var NO_CREATE_MODIFIERS = {
 };
 
 var MODIFIERS = {
+  $currentDate: function (target, field, arg) {
+    if (typeof arg === "object" && arg.hasOwnProperty("$type")) {
+       if (arg.$type !== "date") {
+         throw MinimongoError("Minimongo does currently only support the date type in $currentDate modifiers");
+       }
+    } else if (arg !== true) {
+      throw MinimongoError("Invalid $currentDate modifier");
+    }
+    target[field] = new Date();
+  },
+  $min: function (target, field, arg) {
+    if (typeof arg !== "number") {
+      throw MinimongoError("Modifier $min allowed for numbers only");
+    }
+    if (field in target) {
+      if (typeof target[field] !== "number") {
+        throw MinimongoError("Cannot apply $min modifier to non-number");
+      }
+      if (target[field] > arg) {
+        target[field] = arg;
+      }
+    } else {
+      target[field] = arg;
+    }
+  },
+  $max: function (target, field, arg) {
+    if (typeof arg !== "number") {
+      throw MinimongoError("Modifier $max allowed for numbers only");
+    }
+    if (field in target) {
+      if (typeof target[field] !== "number") {
+        throw MinimongoError("Cannot apply $max modifier to non-number");
+      }
+      if (target[field] < arg) {
+         target[field] = arg;
+      }
+    } else {
+      target[field] = arg;
+    }
+  },
   $inc: function (target, field, arg) {
     if (typeof arg !== "number")
       throw MinimongoError("Modifier $inc allowed for numbers only");

packages/minimongo/package.js

@@ -1,6 +1,6 @@
 Package.describe({
   summary: "Meteor's client-side datastore: a port of MongoDB to Javascript",
-  version: '1.0.18'
+  version: '1.0.19'
 });
 
 Package.onUse(function (api) {

packages/stylus/package.js

@@ -1,6 +1,6 @@
 Package.describe({
   summary: 'Expressive, dynamic, robust CSS',
-  version: "2.513.7"
+  version: "2.513.8"
 });
 
 Package.registerBuildPlugin({

packages/twitter/package.js

@@ -1,6 +1,6 @@
 Package.describe({
   summary: "Twitter OAuth flow",
-  version: '1.1.13'
+  version: '1.1.14'
 });
 
 Package.onUse(function(api) {

packages/twitter/twitter_configure.html

@@ -4,7 +4,7 @@
   </p>
   <ol>
     <li>
-      Visit <a href="https://dev.twitter.com/apps/new" target="_blank">https://dev.twitter.com/apps/new</a>
+      Visit <a href="https://apps.twitter.com/app/new" target="_blank">https://dev.twitter.com/apps/new</a>
     </li>
     <li>
       Set Website to: <span class="url">{{siteUrl}}</span>

scripts/admin/banners.json

@@ -14,5 +14,10 @@
     "banner": {
       "text": "=> Meteor 1.3.4: npm@3.9.6, .babelrc support, improved import declarations,\n   DDP update batching, and more: https://github.com/meteor/meteor/blob/master/History.md#v134\n\n   This release is being downloaded in the background. Update your app to\n   Meteor 1.3.4 by running 'meteor update'."
     }
+  }, {
+    "versions": ["1.4.2"],
+    "banner": {
+      "text": "=> Meteor 1.4.2.1: An important patch release for Meteor 1.4.2:\n   https://forums.meteor.com/t/meteor-1-4-2-1-is-an-important-patch-for-1-4-2-users"
+    }
   }]
 }

scripts/admin/meteor-release-experimental.json

@@ -1,6 +1,6 @@
 {
  "track": "METEOR",
- "version": "1.4.2.1-rc.2",
+ "version": "1.4.2.3-rc.0",
  "recommended": false,
  "official": false,
  "description": "Meteor"

scripts/admin/meteor-release-official.json

@@ -1,7 +1,7 @@
 {
   "track": "METEOR",
-  "version": "1.4.2.1",
-  "patchFrom": ["1.4.2"],
+  "version": "1.4.2.3",
+  "patchFrom": ["1.4.2", "1.4.2.1", "1.4.2.2"],
   "recommended": false,
   "official": true,
   "description": "The Official Meteor Distribution"

scripts/build-dev-bundle-common.sh

@@ -6,7 +6,7 @@ set -u
 UNAME=$(uname)
 ARCH=$(uname -m)
 MONGO_VERSION=3.2.6
-NODE_VERSION=4.6.1
+NODE_VERSION=4.6.2
 NPM_VERSION=3.10.9
 
 if [ "$UNAME" == "Linux" ] ; then

scripts/generate-dev-bundle.ps1

@@ -2,7 +2,7 @@
 # use 32bit by default
 $PLATFORM = "windows_x86"
 $MONGO_VERSION = "3.2.6"
-$NODE_VERSION = "4.6.1"
+$NODE_VERSION = "4.6.2"
 $NPM_VERSION = "3.10.9"
 $PYTHON_VERSION = "2.7.12" # For node-gyp