Added in Meteor.loggingOut() and related Blaze helpers. #8271
Conversation
|
I forgot to mention - I created a small runnable app that shows the |
|
Thanks, 4 years old :) |
|
Hehe, I know - we're in the process of cleaning up old issues @raix so this was uncovered. There is an amazing amount of good stuff, like your changes, that got overlooked! Hopefully more of it starts to filter in soon. Thanks again! |
| @@ -17,6 +17,9 @@ export class AccountsClient extends AccountsCommon { | |||
| this._loggingIn = false; | |||
| this._loggingInDeps = new Tracker.Dependency; | |||
|
|
|||
| this._loggingOut = false; | |||
| this._loggingOutDeps = new Tracker.Dependency; | |||
|
|
|||
There was a problem hiding this comment.
maybe use ReactiveVar:
this._loggingOut = new ReactiveVar(false)There was a problem hiding this comment.
Thanks for the feedback @raix! I didn't use a ReactiveVar since these changes were modelled after the existing loggingIn code. That being said, using a ReactiveVar would definitely clean the code up a bit. I'll look into making these changes, and consider updating the code for loggingIn as well (and add some new tests for that part of the code since there don't seem to be any). Thanks again for taking a look at this!
| if (this._loggingOut !== x) { | ||
| this._loggingOut = x; | ||
| this._loggingOutDeps.changed(); | ||
| } |
There was a problem hiding this comment.
Actually just skip this helper function
| */ | ||
| loggingOut() { | ||
| this._loggingOutDeps.depend(); | ||
| return this._loggingOut; |
There was a problem hiding this comment.
return this._loggingOut.get();
| * @summary Log the user out. | ||
| * @locus Client | ||
| * @param {Function} [callback] Optional callback. Called with no arguments on success, or with a single `Error` argument on failure. | ||
| */ | ||
| logout(callback) { | ||
| var self = this; | ||
| self._setLoggingOut(true); |
| self.connection.apply('logout', [], { | ||
| wait: true | ||
| }, function (error, result) { | ||
| self._setLoggingOut(false); |
There was a problem hiding this comment.
and we could add .set here too
|
I updated things a bit to leverage |
|
I'll try to review this a bit more in detail during/before next week's issue club (couldn't get to it yesterday) but first pass looks good. My only initial thought might be any possibility of a term aside from |
|
Sounds good @abernix - it's been 4 years, so no rush! 😄 I like your |
| * @isHelper true | ||
| * @summary Calls [Meteor.loggingOut()](#meteor_loggingout). | ||
| */ | ||
| Package.blaze.Blaze.Template.registerHelper('loggingOut', function () { |
There was a problem hiding this comment.
I realize there is already code in this file that assumes Package.blaze is defined, but I think I would prefer if we were a bit more defensive about checking whether blaze is installed, since it's only a weak dependency of accounts-base.
There was a problem hiding this comment.
Sounds good - I'll get this resolved - thanks!
There was a problem hiding this comment.
Just reviewing this now - it looks like there is a Package.blaze check just above the helper registration code. Do you think this is defensive enough? I can expand this further by converting the Package.blaze check into a Package.hasOwnProperty('blaze') check, paired with some additional checks to make sure the blaze object contains a Blaze property, but this might be overkill (I think it's pretty safe to assume Package.blaze really only points to a valid blaze object, if truthy). Let me know though - thanks!
There was a problem hiding this comment.
I think Package.blaze is good enough. This is what everyone is doing for weak dependencies.
Hi all - this PR is intended to help address issues #769 and #1331. It's essentially a re-working of the very old PR #826 (submitted by @raix - thanks!). I've modified it to work with the current codebase and added some tests. Let me know if you have any questions / need anything changed. Thanks!