Release 1.4.3.1 #8363
Merged
Release 1.4.3.1 #8363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Although we thought the upgrade from `npm` 3.10.9 to 4.1.2 was worthwhile and safe, this breaking change proved problematic: https://github.com/npm/npm/blob/latest/CHANGELOG.md#no-more-partial-shrinkwraps-breaking Specifically, if a Meteor package calls `Npm.depends` in a way that disagrees with the contents of `.npm/package/npm-shrinkwrap.json` file, Meteor will create a partial shrinkwrap file in order to install the correct top-level npm dependencies, but transitive dependencies of the package will no longer be installed. This was fixed in Meteor 1.4.2.7 by reverting the upgrade of npm, but Meteor 1.4.3.1 will keep npm@4.1.2 and fix the consequences.
Thanks to @abernix for fixing this Babel/Babylon bug in Reify: benjamn/reify#62 Fixes #8312.
benjamn
force-pushed
the
release-1.4.3.1
branch
from
81c94d9
to
ebbc02d
Compare
@abernix Bumping the ecmascript version is apparently necessary if the babel-compiler package has changed, presumably because ecmascript defines a compiler plugin that uses babel-compiler. Unless the ecmascript version has been bumped, babel-compiler changes won't appear to have any effect.
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whereas Meteor 1.4.2.7 fixed #8349 by reverting
npmfrom version 4.1.2 to version 3.10.9, this release fixes the same bug by keepingnpm@4.1.2but dealing with the consequences of this breaking change.This release will also fix #8312, which could have been fixed independently (since it involves only packages), but was easier to fix after fixing the problem described above.
Note that Meteor 1.4.3 has been published, but we have not (and will not) "recommend" it, because of the problem with upgrading npm dependencies of Meteor packages.