/ meteor Public
.bin files maintain executable bits in Windows bundles.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge.
#Windows has no concept of the executable bit so it is not applied by the
Readerwhen building the tarball which is used in both
meteor deploy. For Windows users, this causes important scripts (such as
node-pre-gyp) to not be executable when the bundles are deployed to Unix platforms (such as Galaxy).
To avoid giving every file executable bits, this applies an executable bit to the file only if it has read permission (something Windows is aware of) and if it is in a location that Node bin links are typically placed, the
Additionally, to apply a slightly more conservative approach to the existing logic (which applied executable bits to all directories), this changes that logic to only apply the executable bit to readable directories, thus maintaining some degree of permissions control when building from a Windows system. This is in line with other projects linked in the comments and issues below, such as
node-pre-gypand other projects linked in the
A symptom of this might be an error message such as: