Change Windows "Generate Dev Bundle" script to use common globals. #8505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change allows the Windows "Generate Dev Bundle" script to automatically get the versions of major bundled versions from the same script which the Unix script uses, thus preventing different versions of Node.js, npm, Mongo, etc. from being built into different versions of Meteor, such as what happened when I published Meteor 1.4.3.2 and failed to notice the duplication of variables across different scripts. This behavior now works in a similar way as the 'BUNDLE_VERSION' variable, which is retrieved from the global `meteor` script except this change uses the package versions from the `build-dev-bundle-common.sh` script in the `scripts` directory.
abernix
added a commit
that referenced
this pull request
Mar 21, 2017
In a similar fashion as: * f51c682 (Node.js) * 8ea4158 (npm) * 3470516 (MongoDB) I overlooked the multiplicity of these version variables when updating the major package versions during the release of Meteor 1.4.3.2. While I intend on never making this mistake again, I've also opened #8505 which consolidates these variables to a single location (in `build-dev-bundle-common.sh`) to hopefully prevent this from happening to anyone else!
benjamn
reviewed
Mar 21, 2017
|
@benjamn I tested this locally on Windows 10 Pro but not with a Jenkins build. |
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows the Windows "Generate Dev Bundle" script to
automatically get the versions of major bundled versions from the same
script which the Unix script uses, thus preventing different versions of
Node.js, npm, Mongo, etc. from being built into different versions of
Meteor, such as what happened when I published Meteor 1.4.3.2 and failed
to notice the duplication of variables across different scripts. (Sorry!)
This behavior now works in a similar way as the
BUNDLE_VERSIONvariable, whichis retrieved from the global
meteorscript except this change uses thepackage versions from the
build-dev-bundle-common.shscript in thescriptsdirectory.Hopefully this will prevent a mistake like this in the future!