Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Windows "Generate Dev Bundle" script to use common globals. #8505

Conversation

@abernix
Copy link
Member

@abernix abernix commented Mar 21, 2017

This change allows the Windows "Generate Dev Bundle" script to
automatically get the versions of major bundled versions from the same
script which the Unix script uses, thus preventing different versions of
Node.js, npm, Mongo, etc. from being built into different versions of
Meteor, such as what happened when I published Meteor 1.4.3.2 and failed
to notice the duplication of variables across different scripts. (Sorry!)

This behavior now works in a similar way as the BUNDLE_VERSION variable, which
is retrieved from the global meteor script except this change uses the
package versions from the build-dev-bundle-common.sh script in the
scripts directory.

Hopefully this will prevent a mistake like this in the future!

benjamn and others added 3 commits Mar 16, 2017
This change allows the Windows "Generate Dev Bundle" script to
automatically get the versions of major bundled versions from the same
script which the Unix script uses, thus preventing different versions of
Node.js, npm, Mongo, etc. from being built into different versions of
Meteor, such as what happened when I published Meteor 1.4.3.2 and failed
to notice the duplication of variables across different scripts.

This behavior now works in a similar way as the 'BUNDLE_VERSION' variable, which
is retrieved from the global `meteor` script except this change uses the
package versions from the `build-dev-bundle-common.sh` script in the
`scripts` directory.
@abernix abernix requested a review from benjamn Mar 21, 2017
abernix added a commit that referenced this pull request Mar 21, 2017
In a similar fashion as:

* f51c682 (Node.js)
* 8ea4158 (npm)
* 3470516 (MongoDB)

I overlooked the multiplicity of these version variables when updating the major package versions during the release of Meteor 1.4.3.2.

While I intend on never making this mistake again, I've also opened #8505 which consolidates these variables to a single location (in `build-dev-bundle-common.sh`) to hopefully prevent this from happening to anyone else!
Copy link
Member

@benjamn benjamn left a comment

Have you used this to generate a dev bundle on Windows yet? As long as it does the right thing, I'm happy.

@abernix
Copy link
Member Author

@abernix abernix commented Mar 21, 2017

@benjamn I tested this locally on Windows 10 Pro but not with a Jenkins build.

@benjamn benjamn changed the base branch from devel to release-1.4.3.x Mar 21, 2017
@benjamn
Copy link
Member

@benjamn benjamn commented Mar 21, 2017

Merged, thanks!

@benjamn benjamn closed this Mar 21, 2017
@abernix abernix deleted the abernix:abernix/feature/fix-win-gen-dev-bundle-script branch Mar 21, 2017
abernix added a commit that referenced this pull request Mar 22, 2017
For #8503 and #8505.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants