Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upConversation
benjamn
and others
added some commits
Mar 16, 2017
abernix
requested a review
from
benjamn
Mar 21, 2017
added a commit
that referenced
this pull request
Mar 21, 2017
benjamn
reviewed
Mar 21, 2017
Have you used this to generate a dev bundle on Windows yet? As long as it does the right thing, I'm happy.
This comment has been minimized.
This comment has been minimized.
|
@benjamn I tested this locally on Windows 10 Pro but not with a Jenkins build. |
benjamn
changed the base branch from
devel
to
release-1.4.3.x
Mar 21, 2017
This comment has been minimized.
This comment has been minimized.
|
Merged, thanks! |
benjamn
closed this
Mar 21, 2017
abernix
deleted the
abernix:abernix/feature/fix-win-gen-dev-bundle-script
branch
Mar 21, 2017
added a commit
that referenced
this pull request
Mar 22, 2017
abernix
referenced this pull request
Apr 3, 2017
Closed
Meteor v1.4.3.2 node version confusion #8554
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
abernix commentedMar 21, 2017
This change allows the Windows "Generate Dev Bundle" script to
automatically get the versions of major bundled versions from the same
script which the Unix script uses, thus preventing different versions of
Node.js, npm, Mongo, etc. from being built into different versions of
Meteor, such as what happened when I published Meteor 1.4.3.2 and failed
to notice the duplication of variables across different scripts. (Sorry!)
This behavior now works in a similar way as the
BUNDLE_VERSIONvariable, whichis retrieved from the global
meteorscript except this change uses thepackage versions from the
build-dev-bundle-common.shscript in thescriptsdirectory.Hopefully this will prevent a mistake like this in the future!