Use UglifyJS when possible, but fall back to Babel.minify. #8519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This gives us all the benefits of @sethmurphy18's great work without the additional performance hit of using Babili for everything. With this commit: % meteor create min-test % cd min-test % time meteor build ../min-build meteor build ../min-build 39.26s user 5.49s system 112% cpu 39.647 total Without this commit: meteor build ../min-build 59.28s user 5.23s system 107% cpu 1:00.08 total Keep in mind this is the best-case scenario for Babili (a very small app). Larger apps take much longer for Babili to minify. cc @abernix @glasser @sethmurphy18
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gives us all the benefits of @sethmurphy18's great work without the additional performance hit of using Babili for everything.
With this commit:
Without this commit:
Keep in mind this is the best-case scenario for Babili (a very small app). Larger apps take much longer for Babili to minify.
cc @abernix @glasser @sethmurphy18