Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Cordova up to 7.0.1 #8919

Closed
wants to merge 3 commits into from
Closed

Update Cordova up to 7.0.1 #8919

wants to merge 3 commits into from

Conversation

janowsiany
Copy link
Contributor

@janowsiany janowsiany commented Jul 17, 2017

#8686
Tried to upgrade Cordova up to 7.0.1 release. This was not as easy as i tougth and end up with bumping the package version only.
The error which i have encountered is:

While adding platform Android to Cordova project:
TypeError: cordovaProject.projectConfig.getFileResources is not a function at updateFileResources

Any one could give me a clue so i could finish this up?

@apollo-cla
Copy link

@janowsiany: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

@skirunman
Copy link
Contributor

We really need Cordova 7 support.

@skirunman
Copy link
Contributor

@wojtkowiak are you interested in Cordova 7 support and/or ability to decouple Cordova from Meteor as per meteor/meteor-feature-requests#112

@janowsiany is willing to do the work, but is looking for some guidance.

@benjamn
Copy link
Contributor

benjamn commented Jul 18, 2017

This change requires building a new dev bundle, which doesn't happen automatically. To rebuild the dev bundle locally, in a checkout of meteor/meteor:

rm -rf dev_bundle
scripts/generate-dev-bundle.sh
meteor --help

I'll need to rebuild the dev bundle and publish it to S3 for the tests to pass here, though.

@benjamn
Copy link
Contributor

benjamn commented Jul 18, 2017

I went ahead and merged this into the release-1.5.2 branch with a new dev bundle version, since the failing tests seemed to be fixed by updating the dev bundle:

Provided all the Cordova-related tests pass on that branch, I'll publish a new beta of 1.5.2, and I would appreciate everyone's help validating it.

@abernix
Copy link
Contributor

abernix commented Jul 18, 2017

Since it's related to Cordova updates, it probably makes sense to update the cordova-plugin-meteor-webapp npm/plugin to include meteor/cordova-plugin-meteor-webapp#25. Therefore, I've just published that plugin to npm as 1.4.2. I've updated this directly on the release-1.5.2 branch via 4fe8541.

@benjamn
Copy link
Contributor

benjamn commented Jul 19, 2017

Please test these changes with your Cordova apps after running meteor update --release 1.5.2-beta.3! If there are any additional changes needed, I would recommend submitting PRs against the release-1.5.2 branch, since these changes are not yet on devel.

@benjamn benjamn changed the base branch from devel to release-1.5.2 July 19, 2017 16:05
@benjamn benjamn changed the title [Work in progress] Update Cordova up to 7.0.1 Update Cordova up to 7.0.1 Jul 19, 2017
@janowsiany
Copy link
Contributor Author

janowsiany commented Jul 19, 2017

@benjamn thanks for your guidance
meteor@1.5.2-beta.3 builds successfully for cordova-ios and cordova-android

@skirunman
Copy link
Contributor

I am able to build successfully with Xcode 8.3.2 on Mac OS 10.12.5 using the 1.5.2-beta.3 release. I removed /.meteor/local before building, but I'm getting these warning messages:

WARNING: Attempting to install plugin cordova-plugin-splashscreen@4.0.1, but it should have a minimum
         version of 4.0.3 to ensure compatibility with the current platform versions. Installing the
         minimum version for convenience, but you should adjust your dependencies.
WARNING: Attempting to install plugin cordova-plugin-inappbrowser@1.6.1, but it should have a minimum
         version of 1.7.1 to ensure compatibility with the current platform versions. Installing the
         minimum version for convenience, but you should adjust your dependencies.
WARNING: Attempting to install plugin cordova-plugin-geolocation@2.1.0, but it should have a minimum
         version of 2.4.3 to ensure compatibility with the current platform versions. Installing the
         minimum version for convenience, but you should adjust your dependencies.
WARNING: Attempting to install plugin cordova-plugin-statusbar@2.2.1, but it should have a minimum version
         of 2.2.3 to ensure compatibility with the current platform versions. Installing the minimum
         version for convenience, but you should adjust your dependencies.

even though when I check /.meteor/local/cordova-build/plugins/ it looks like the correct and more recent versions of the plugins are in fact installed.

@skirunman
Copy link
Contributor

I was also able to build successfully for Android targeting API 25 using Android SDK tools v26.0.2. This probably means that these issues are also resolved: #8408 #8424 #8464

@benjamn
Copy link
Contributor

benjamn commented Jul 23, 2017

Fully merged into release-1.5.2. Thanks again!

@benjamn benjamn closed this Jul 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants