Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring back deprecated stylus package in order to fix a caching bug. #9565

Merged
merged 3 commits into from
Jan 22, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
@@ -0,0 +1 @@
node_modules
@@ -0,0 +1,7 @@
This directory and the files immediately inside it are automatically generated
when you change this package's NPM dependencies. Commit the files in this
directory (npm-shrinkwrap.json, .gitignore, and this README) to source control
so that others run the same versions of sub-dependencies.

You should NOT check in the node_modules directory that Meteor automatically
creates; if you are using git, the .gitignore file tells git to ignore it.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

35 changes: 35 additions & 0 deletions packages/deprecated/stylus/.versions
@@ -0,0 +1,35 @@
babel-compiler@5.8.24_1
babel-runtime@0.1.4
base64@1.0.9
binary-heap@1.0.9
blaze@1.0.3
caching-compiler@1.0.0
callback-hook@1.0.9
check@1.0.6
ddp@1.1.0
deps@1.0.12
ecmascript@0.1.4
ecmascript-collections@0.1.6
ejson@1.0.12
geojson-utils@1.0.4
htmljs@1.0.11
id-map@1.0.8
jquery@1.0.2
json@1.0.3
local-test:stylus@2.513.5
logging@1.0.12
meteor@1.1.16
minimongo@1.0.8
mongo@1.1.0
observe-sequence@1.0.6
ordered-dict@1.0.8
promise@0.4.8
random@1.0.4
retry@1.0.4
stylus@2.513.5
templating@1.0.4
test-helpers@1.0.3
tinytest@1.0.5
tracker@1.0.15
ui@1.0.0
underscore@1.0.9
2 changes: 1 addition & 1 deletion packages/deprecated/stylus/README.md
Expand Up @@ -4,7 +4,7 @@

**DEPRECATED:** This package is no longer supported/maintained as part of the
Meteor project. To continue using the last supported version of this package,
pin your package version to 2.513.13 (`meteor add stylus@=2.513.13`).
pin your package version to 2.513.14 (`meteor add stylus@=2.513.14`).

[Stylus](http://learnboost.github.com/stylus/) is a CSS pre-processor with a
simple syntax and expressive dynamic behavior. It allows for more compact
Expand Down
14 changes: 7 additions & 7 deletions packages/deprecated/stylus/deprecation_notice.js
@@ -1,7 +1,7 @@
console.warn(
"The `stylus` package has been deprecated.\n" +
"\n" +
"To continue using the last supported version \n" +
"of this package, pin your package version to \n" +
"2.513.13 (`meteor add stylus@=2.513.13`)."
);
console.warn([
"The `stylus` package has been deprecated.",
"",
"To continue using the last supported version",
"of this package, pin your package version to",
"2.513.14 (`meteor add stylus@=2.513.14`).",
].join("\n"));
30 changes: 27 additions & 3 deletions packages/deprecated/stylus/package.js
@@ -1,8 +1,32 @@
Package.describe({
summary: 'DEPRECATED - Expressive, dynamic, robust CSS',
version: "2.999.0"
summary: 'Expressive, dynamic, robust CSS',
version: "2.513.14"
});

Package.registerBuildPlugin({
name: 'compileStylusBatch',
use: ['ecmascript', 'caching-compiler'],
sources: [
'plugin/compile-stylus.js'
],
npmDependencies: {
stylus: "https://github.com/meteor/stylus/tarball/bb47a357d132ca843718c63998eb37b90013a449", // fork of 0.54.5
nib: "1.1.2",
"autoprefixer-stylus": "0.9.4"
}
});

Package.onUse(function (api) {
api.addFiles('deprecation_notice.js');
api.use('isobuild:compiler-plugin@1.0.0');
api.addFiles("deprecation_notice.js");
});

Package.onTest(function (api) {
api.use(['tinytest', 'stylus', 'test-helpers', 'templating']);
api.addFiles([
'stylus_tests.html',
'stylus_tests.styl',
'stylus_tests.import.styl',
'stylus_tests.js'
],'client');
});