Bring back deprecated stylus package in order to fix a caching bug. #9565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This code was recently removed in PR #9445, with this commit: d644705 Rather than removing deprecated code entirely from the codebase, I think it's sufficient to keep it in packages/deprecated, and print a deprecation notice whenever the package is used. This way it's clear that developers should migrate to other similar packages, but we can still release important patches for those who haven't been able to migrate yet. cc @hwillson @abernix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code was recently removed in PR #9445, with this commit: d644705
Rather than removing deprecated code entirely from the codebase, I think it's sufficient to keep it in packages/deprecated, and print a deprecation notice whenever the package is used. This way it's clear that developers should migrate to other similar packages, but we can still release important patches for those who haven't been able to migrate yet.