Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bring back deprecated stylus package in order to fix a caching bug. #9565

Merged
merged 3 commits into from Jan 22, 2018
Merged

Bring back deprecated stylus package in order to fix a caching bug. #9565

merged 3 commits into from Jan 22, 2018

Commits on Jan 22, 2018

  1. Bring back deprecated stylus package in order to fix a caching bug. 

    This code was recently removed in PR #9445, with this commit:
d644705

Rather than removing deprecated code entirely from the codebase, I think
it's sufficient to keep it in packages/deprecated, and print a deprecation
notice whenever the package is used. This way it's clear that developers
should migrate to other similar packages, but we can still release
important patches for those who haven't been able to migrate yet.

cc @hwillson @abernix
    @benjamn
    benjamn committed Jan 22, 2018
    Configuration menu
    Copy the full SHA
    a5fc5b0 View commit details
    Browse the repository at this point in the history

  2. Include inputFile.getArch() in StylusCompiler cache key. 

    Similar to this CachedCoffeeScriptCompiler change:
620689f

And this LessCompiler change: 8cadd4e
    @benjamn
    benjamn committed Jan 22, 2018
    Configuration menu
    Copy the full SHA
    f1f2878 View commit details
    Browse the repository at this point in the history

  3. Bump stylus patch version to 2.513.14 and update references.

    @benjamn
    benjamn committed Jan 22, 2018
    Configuration menu
    Copy the full SHA
    4116177 View commit details
    Browse the repository at this point in the history