New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default and --minimal app skeletons. Fixes #9961 #9977

Merged
merged 1 commit into from Jun 11, 2018

Conversation

Projects
None yet
2 participants
@robfallows
Contributor

robfallows commented Jun 11, 2018

Rename test/ folder to tests/

Removing the 1.7 meteor stanza from package.json should restore legacy eager loading with imports/ behaviour, but the presence of the test/ folder, which now becomes eagerly loaded breaks the build.

The Meteor Guide recommends the use of a tests/ folder. This PR renames test/ to tests/ and updates the package.json accordingly for the default app (including the --minimal version).

Test

Using Meteor 1.7+

meteor create my-app (or meteor create my-app --minimal`)
cd my-app

Edit package.json and remove the entire meteor stanza. Then

meteor npm i
meteor

The app should start without errors.

@benjamn benjamn merged commit a52b462 into meteor:devel Jun 11, 2018

2 of 5 checks passed

ci/circleci: Get Ready CircleCI is running your tests
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
CLA Author has signed the Meteor CLA.
Details
ci/circleci: Docs Your tests passed on CircleCI!
Details

@benjamn benjamn added this to the Release 1.7.1 milestone Jun 11, 2018

@benjamn

This comment has been minimized.

Member

benjamn commented Jun 11, 2018

Thanks @robfallows!

benjamn added a commit that referenced this pull request Jun 13, 2018

benjamn added a commit that referenced this pull request Jun 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment