-
Notifications
You must be signed in to change notification settings - Fork 366
React unit test warnings #144
Comments
Possibly related: enzymejs/enzyme#47
This is a webpack configuration though -- don't know if it relates at all to NPM and/or Meteor... |
I'd like to dig deeper into this one. As you've pointed out, it is just a warning so I'm not super concerned about it; however it would be good to get a better handle on these kind of warnings as there is often real, important information buried amongst the warnings. |
I am also seeing this error while trying to use In Terminal 1 . . .
Results in :
In Terminal 2 . . .
Results in :
¡¡ However, since all tests are in directories named In Terminal 3 . . .
Results in :
To make it failIn Terminal 3 . . .
In Terminal 1 . . .Results in :
Versions
|
Ok, reading up on this bug: enzymejs/enzyme#47 it seems like this is about Enzyme doing some conditional out of date It's nothing to worry about, but it would be nice to remove the warning. @benjamn, any suggestions about whether there's any way to silence warnings about known missing conditionally In webpack-land the accepted solution seems to be externalizing those dependencies in your webpack config. |
Not sure what changed over the last couple of months, but pulling the react branch from this repo, installing npm dependencies and then running test-watch results in the console log included below(in the browser). The server console also shows the warning discussed in this issue. The client side tests don't seem to run at all, so client-side testing is completely broken in the current state of the react branch. When I remove the "import enzyme.. " line and the other enzyme references, the tests run without any issues. So it seems this error is directly related to enzyme.
|
In case anyone is looking for a temporary solution, it seems a recent update of enzyme is what breaks the unit tests. Version 2.4.1 works, version 2.7.1 breaks. So setting the package.json entry to "=2.4.1" instead of "^2.4.1" fixes the unit tests. |
For me version 2.4.1 gives the same error... |
React |
When I run the
react
branch unit tests, I see the following error repeated three times (on MacOS El Capitan):I believe they are caused by my pull request #141 but I'm not sure how to go about debugging this, and have already spent a few hours playing around with NPM and package versions.
Anybody have suggestions?
The text was updated successfully, but these errors were encountered: