Skip to content
This repository has been archived by the owner on Feb 26, 2021. It is now read-only.

First pass at showing errors via i18n #41

Closed
wants to merge 1 commit into from
Closed

First pass at showing errors via i18n #41

wants to merge 1 commit into from

Conversation

tmeasday
Copy link
Contributor

Can I get your thoughts on this @stubailo?

A couple of things:

  1. Where to put the helper and is it weird to get the translation in the helper? (it means I have to do vaguely funky things to get a "symbol" from another package)
  2. Are we going to i18n-ise the whole app? Because that's probably going to be a chunk of work. I wonder if we can just show this pattern somehow
  3. It's kind of annoying to use but that's probably just how it goes with this stuff. All-packages doesn't make it easy...

"Lists": {
"methods": {
"remove": {
"lastPublicList": "Cannot delete the last public list."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me - I love the namespacing. Although, this is one place there could be a lot of benefit to having all of the translations in one file - that way you could just give the file to a translation service and get all of the different languages, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well I think we are running up against a limitation of the all-package approach here perhaps?

@stubailo
Copy link
Contributor

stubailo commented Dec 9, 2015

Should we wait on this until the modules preview drops?

@tmeasday
Copy link
Contributor Author

We are going to do this properly when we hit 1.3 / modules #59

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants