Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api-gitlab-v4): workaround for gitlab redirect_uri issue (close #99) #101

Closed
wants to merge 1 commit into from

Conversation

mohan43u
Copy link

@mohan43u mohan43u commented Jul 3, 2020

fix(api-gitlab-v4): workaround for gitlab redirect_uri issue (close #99)

@mohan43u
Copy link
Author

mohan43u commented Jul 3, 2020

I have fixed gitlab redirect_uri issue. Also fixed related test cases as well as code coverage. I would like to see this PR reviewed and hopefully merged.

@mohan43u mohan43u mentioned this pull request Jul 3, 2020
2 tasks
@CieNTi
Copy link

CieNTi commented Aug 27, 2020

Thanks for all your work @meteorlxy and @mohan43u .. great system!

Do you have some expectation on when this feature will be added to an official release of vssue?

Thanks!

@CieNTi
Copy link

CieNTi commented Sep 6, 2020

Hi again!

It is possible to use your version @mohan43u ? I cannot figure how to use a named-space plugin out of the original source, and is not possible to add dependencies based on a subfolder of a repository.

How can I use it while we wait for official releases that fix support to Gitlab?

Thanks!

@mohan43u
Copy link
Author

@CieNTi you have to build vssue.gitlab.min.js, here is the steps

  1. Install yarn which will automatically install node
  2. From the cloned directory run following command to install dependencies
$ yarn install
  1. Then run lint
$ yarn lint
  1. Then run build, this will generate packages/vssue/dist/vssue.gitlab.min.js file, use this file in your project
$ yarn build
  1. You should also run the testcases
$ yarn test

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stale
Copy link

stale bot commented Jul 30, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Stale issues or pull requests label Jul 30, 2021
@stale stale bot closed this Aug 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Stale issues or pull requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] make redirect_uri work until gitlab fix their issue.
2 participants