Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: trigger rule #54

Merged
merged 2 commits into from
Jun 6, 2023
Merged

feat: trigger rule #54

merged 2 commits into from
Jun 6, 2023

Conversation

TaiYou-TW
Copy link
Contributor

Done #30.

但這個目前只是能在被執行時去尋找並觸發警報,還需要 @as535364 實作完剩下的部分。(所以也麻煩 @as535364 reiew 一下)

Change logs

  • 新增 TriggerRuleJob,執行時會尋找滿足條件的 Rule 並觸發
  • 修正 API document 無法支援 Enum 的問題
  • 將部分 model 中應為或不應為 Optional 的欄位修正

@TaiYou-TW TaiYou-TW requested a review from Bogay June 6, 2023 17:32
@TaiYou-TW
Copy link
Contributor Author

現在好累所以 code 很醜
目前腦袋無法運轉所以暫時也沒辦法補 testing
sorry QQ

Copy link
Contributor

@Bogay Bogay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Bogay
Copy link
Contributor

Bogay commented Jun 6, 2023

現在好累所以 code 很醜 目前腦袋無法運轉所以暫時也沒辦法補 testing sorry QQ

辛苦了,剩下就直接串 celery 跑看看吧

@Bogay Bogay merged commit e336eb9 into main Jun 6, 2023
@Bogay Bogay deleted the feat/trigger_rule_job branch June 6, 2023 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants