Fix Issue #36: client.meta.users failing #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruprict
commented
Feb 16, 2018
| MultiXml.parse(response, symbolize_keys: true) | ||
| typecast = options.fetch(:typecast_values, true) | ||
| MultiXml.parse(response, | ||
| symbolize_keys: true, |
There was a problem hiding this comment.
Layout/AlignHash: Align the elements of a hash literal if they span more than one line.
ruprict
commented
Feb 16, 2018
| def tables | ||
| request( | ||
| :get, "meta/tables", | ||
| typecast_values: false)[:tables] |
There was a problem hiding this comment.
Layout/MultilineMethodCallBraceLayout: Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue stems from the various ways the Bamboo HR API returns results
for the metadata endpoints. The original code tried to handle it with
metaprogramming, but the returning results are not the same.
Added tests and methods specific to the four metadata endpoints.
Address Issue #36