This repository has been archived by the owner on Apr 28, 2023. It is now read-only.
DIGCOLL-5749 change Marble banner padding #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidseguin
requested review from
JosephCurley and
stephenhmarsh
as code owners
…rble into DIGCOLL-5749-banner
stephenhmarsh
approved these changes
Aug 31, 2022
JosephCurley
approved these changes
Sep 6, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new variable measurement is a little unpredictable on the Marble banner: the padding gets fuller at larger screens (as the code is meant to do) but design prefers it to stay at 7.5vw at all sizes