Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fcm make: correctly report no such config file #155

Merged
merged 1 commit into from
Nov 3, 2014

Conversation

matthewrmshin
Copy link
Member

Fix #154.

@matthewrmshin
Copy link
Member Author

@benfitzpatrick please review.

run_fail "$TEST_KEY" fcm make -f bad-name.cfg
file_cmp "$TEST_KEY.err" "$TEST_KEY.err" <<'__ERR__'
[FAIL] bad-name.cfg: no such configuration file

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extra line?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, same as t/fcm-make/26-no-config.t.

(The reason is that it allows the error message to stand out if you run fcm make on the command line.)

benfitzpatrick added a commit that referenced this pull request Nov 3, 2014
fcm make: correctly report no such config file
@benfitzpatrick benfitzpatrick merged commit e542286 into metomi:master Nov 3, 2014
@matthewrmshin matthewrmshin deleted the fcm-make-no-such-cfg branch November 3, 2014 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fcm 2014.09.0 make: improve error message if config file missing
2 participants