Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fcm make: allow multiple runs in same directory #188

Merged
merged 5 commits into from
May 8, 2015

Conversation

matthewrmshin
Copy link
Member

A make can now be named, so multiple non-overlapping makes can work in
the same directory.

Close #126.

@matthewrmshin
Copy link
Member Author

@benfitzpatrick please review.

A make can now be named, so multiple non-overlapping makes can work in
the same directory.
use = /path/to/succeeded/make/
</pre>

<p>For more information on how an inheritance behave, see:</p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

behaves

@matthewrmshin
Copy link
Member Author

Doc typo fixed.

@@ -36,10 +36,11 @@ my $E = 'FCM::System::Exception';

# Configuration parser label to action map
my %CONFIG_PARSER_OF = (
'dest' => \&_parse_dest,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I preferred this way of doing it

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The old way has been restored.

end program hello
__FORTRAN__

fcm make -q -C "${PWD}/hello" -n '-friend'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might as well do a 'run_pass'?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

build.source=$HERE/src
build.target{task}=link
__CFG__
run_fail "${TEST_KEY_BASE}-snub" fcm make -C "${PWD}/snub" -n '-no-friend'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the error message like? Can we have a grep?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@benfitzpatrick
Copy link
Contributor

One remaining comment (the 'grep' one).

@benfitzpatrick
Copy link
Contributor

We will have to be careful to match versions across platforms - a new-fcm's extract breaks old-fcm's build.

benfitzpatrick added a commit that referenced this pull request May 8, 2015
fcm make: allow multiple runs in same directory
@benfitzpatrick benfitzpatrick merged commit 08f0ed3 into metomi:master May 8, 2015
@matthewrmshin matthewrmshin deleted the ctx-name branch May 8, 2015 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fcm make: skipping the mirror step
2 participants