rose suite-clean: improve parent directory clean #2031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Looks good, tested as working. One comment:
I tested this by doing something like
$ rose suite-run -C foo/bar --name foo/bar
$ rose suite-run -C foo/baz --name foo/baz
$ sleep 60
$ rose suite-clean --name foo/bar
$ rose suite-clean --name foo/baz
rose suite-clean left behind the empty directory cylc-run/foo.
For suite under sub-directory hierarchy, clean all the way to the root where possible.
matthewrmshin
force-pushed
the
rose-suite-clean-hierarchy-parent
branch
from
cb85ceb
to
d0023d0
Compare
@oliver-sanders It doesn't in my environment, so we'll need to figure out why it does so in your environment. (The new test should also pick up on this if it does.) |
oliver-sanders
approved these changes
Jan 3, 2017
There was a problem hiding this comment.
After re-running my test against 7.0.0 and master I can see no problems (d0023d0).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For suite under sub-directory hierarchy, clean all the way to the root
where possible.