Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rose bush: taskjobs: uncheck all task statuses link #2048

Merged

Conversation

matthewrmshin
Copy link
Member

Add link to un-check all task statuses.

@arjclark
Copy link
Contributor

So, have just struggled to find the link and took @oliver-sanders a moment to remember where it was. Discussing, could you put the link there as inactive so it is at least always displayed even if not useable.

Additionally, I'd also prefer this as a button rather than a hyperlink as, typically, a button is there for performing an operation while a hyperlink takes you to a new page (though I acknowledge that a button's function can be to take you to a new page).

@arjclark
Copy link
Contributor

@matthewrmshin - can you record your responses on here please and then I'll look to merge.

@matthewrmshin matthewrmshin force-pushed the rose-bush-taskjobs-uncheck-task-statuses branch from 5e82807 to 54b48f9 Compare February 22, 2017 13:05
@matthewrmshin
Copy link
Member Author

@arjclark I have push a new changeset in to keep you happy (as I am in such a good mood today).

@arjclark
Copy link
Contributor

@matthewrmshin - It's a thing of beauty that makes me very happy 😁

@arjclark arjclark merged commit 91a148d into metomi:master Feb 22, 2017
@matthewrmshin matthewrmshin deleted the rose-bush-taskjobs-uncheck-task-statuses branch February 22, 2017 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants