Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rose suite-clean --only=extglob #2050

Merged
merged 2 commits into from
Feb 13, 2017

Conversation

matthewrmshin
Copy link
Member

Remove Python logic for cleaning localhost - as the Python standard library glob cannot handle extended glob. Use the same bash-based logic as remote job host for localhost to implement this functionality and for consistency.

Close #2029.

Copy link
Contributor

@arjclark arjclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good change to me.

Copy link
Member

@oliver-sanders oliver-sanders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
The CLI will need to be updated to document this new extglob feature.

@matthewrmshin
Copy link
Member Author

Doc updated.

@oliver-sanders oliver-sanders merged commit 8698c9a into metomi:master Feb 13, 2017
@matthewrmshin matthewrmshin deleted the rose-suite-clean-extglob branch February 13, 2017 16:32
@matthewrmshin matthewrmshin mentioned this pull request Feb 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants