Remove port file related logic #2109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvalters
reviewed
Sep 8, 2017
| @@ -204,7 +204,7 @@ class SuiteStillRunningError(Exception): | |||
| FMT_HEAD = "Suite \"%(suite_name)s\" has running processes on:" | |||
| FMT_BODY_1 = " %(host_name)s" | |||
| FMT_BODY_M = "\n %(host_name)s" | |||
| FMT_TAIL = "\nTry \"rose suite-shutdown --name=%(suite_name)s\" first?" | |||
| FMT_TAIL = "\nTry \"cylc stop '%(suite_name)s'\" first?" | |||
There was a problem hiding this comment.
Is there a reason for switching this? i.e. Rose to recommend running a Cylc command (I mean I guess in practice people almost always have Rose + Cylc), just wondered.
There was a problem hiding this comment.
rose suite-shutdown was an essential command for picking the correct suite host for the cylc stop command. It became unnecessary since cylc/cylc-flow#1705, and I would like to encourage users to call cylc stop directly to reduce overhead.
oliver-sanders
approved these changes
Sep 12, 2017
dvalters
reviewed
Sep 19, 2017
|
@matthewrmshin also |
Trust the cylc 7 contact file as an indicator that a suite is running.
matthewrmshin
force-pushed
the
trust-contact-file
branch
from
cede019
to
125aed2
Compare
|
The tests are both OK in my environment, (but I guess it is worth checking what is causing the failure in your environment). Neither tests should be related to this change. |
dvalters
approved these changes
Sep 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trust the cylc 7 contact file as an indicator that a suite is running.