Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Frontend: navigate to routes with fragment string #377

Closed
lucywang000 opened this issue Mar 16, 2020 · 2 comments
Closed

Frontend: navigate to routes with fragment string #377

lucywang000 opened this issue Mar 16, 2020 · 2 comments
Assignees
@Deraen
Labels
frontend

Comments

@lucywang000
Copy link

with the current code, when using h5 history, there is no way to push state to a url like "/path#foo" because reitit.frontend.history/push-state doesn't take that into consideration. Is that correct? If so i may submit a pr to address that.
@lucywang000
Copy link
Author

ping @ikitommi

@Deraen Deraen self-assigned this Mar 23, 2023
@Deraen
Copy link
Member

Deraen commented Mar 23, 2023 •
edited
Loading

#581 added support for reading fragment string from the URI to match, but we still don't have way to create URIs with fragments in Reitit-frontend.

Todo:

  • href
  • push-state & replace-state

@Deraen Deraen changed the title frontend: h5 history push-state doesn't support hash Frontend: navigate to routes with fragment string Mar 23, 2023
Deraen added a commit that referenced this issue Mar 24, 2023
@Deraen
Fix #377, navigate to routes with fragment string in frontend
babbb1b
Deraen added a commit that referenced this issue Mar 24, 2023
@Deraen
Fix #377, navigate to routes with fragment string in frontend
3a161c9
@Deraen Deraen mentioned this issue Mar 24, 2023
Open
Deraen added a commit that referenced this issue Mar 24, 2023
@Deraen
Fix #377, navigate to routes with fragment string in frontend
09643e1
@Deraen Deraen closed this as completed in 56e6dbe May 4, 2023
Deraen added a commit that referenced this issue May 4, 2023
@Deraen
Merge pull request #604 from metosin/fix-377-fragment-strings
9f6565f 
Fix #377, navigate to routes with fragment string in frontend
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Deraen Deraen

Labels
frontend
Projects
Metosin Open Source Backlog
Status: ✅ Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Deraen @lucywang000