Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix protocol extension (for cljs) #35

Merged
merged 1 commit into from
May 3, 2020
Merged

Fix protocol extension (for cljs) #35

merged 1 commit into from
May 3, 2020

Conversation

zelark
Copy link
Contributor

@zelark zelark commented May 3, 2020

@ikitommi
Copy link
Member

ikitommi commented May 3, 2020

Hi. Actually default would cover all cases: https://github.com/clojure/clojurescript/blob/master/src/main/clojure/cljs/core.cljc#L1312-L1328. Could you change to that?

@zelark
Copy link
Contributor Author

zelark commented May 3, 2020

Hi, sure.

@zelark
Copy link
Contributor Author

zelark commented May 3, 2020

Just changed. Didn't know about default. Thank you.

@ikitommi ikitommi merged commit 7beacf8 into metosin:develop May 3, 2020
@ikitommi
Copy link
Member

ikitommi commented May 3, 2020

Thanks!

@zelark zelark deleted the fix-js-obj branch May 3, 2020 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zelark @ikitommi