Avoid race conditions #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some actions like waiting for running operations et cetera need to happen in order for the action to work well. Otherwise the action is prone to race conditions. Thus, this change adds await statements in all methods where we must await the result.
|
I don't know why the pre-commit workflow failed. Seems to be some temporary condition? Can someone of the maintainers rerun the job? |
cova-fe
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some actions like waiting for running operations et cetera need
to happen in order for the action to work well. Otherwise the
action is prone to race conditions. Thus, this change adds await
statements for all methods where we must await the result.