Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure mutually-exclusive "none" option for Vouchers question #761

Merged
merged 2 commits into from
Jul 26, 2024

Conversation

jaredcwhite
Copy link
Collaborator

@jaredcwhite jaredcwhite commented Jul 24, 2024

This PR addresses #751

  • Addresses the issue in full
  • Addresses only certain aspects of the issue

Description

When you get to the Common App question about Section 8 vouchers, etc., you'll see that if you select None of the above, it deselects the other options—and when you select one of those, None is deselected.

How Can This Be Tested/Reviewed?

Fill out Common App, verify the option selection

Author Checklist:

  • Added QA notes to the issue with applicable URLs
  • Reviewed in a desktop view
  • Reviewed in a mobile view
  • Reviewed considering accessibility
  • Added tests covering the changes
  • Made corresponding changes to the documentation
  • Ran yarn generate:client and/or created a migration when required

Review Process:

  • Read and understand the issue
  • Ensure the author has added QA notes
  • Review the code itself from a style point of view
  • Pull the changes down locally and test that the acceptance criteria is met
  • Either (1) explicitly ask a clarifying question, (2) request changes, or (3) approve the PR, even if there are very small remaining changes, if you don't need to re-review after the updates

Copy link
Collaborator

@mcgarrye mcgarrye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcgarrye mcgarrye added ready to merge Should be applied when a PR has been reviewed and approved and removed 1 review needed labels Jul 25, 2024
@mcgarrye
Copy link
Collaborator

Actually! Question for @sarahlazarich and @jaredcwhite, should we fix this for the paper application as well in this ticket?

@jaredcwhite
Copy link
Collaborator Author

@mcgarrye @sarahlazarich I think we should!

@sarahlazarich
Copy link
Collaborator

@jaredcwhite, let's handle that as a follow up actually!

@jaredcwhite jaredcwhite merged commit 8575344 into main Jul 26, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Should be applied when a PR has been reviewed and approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants