Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: lottery expiration #764

Closed
wants to merge 1 commit into from
Closed

Conversation

mcgarrye
Copy link
Collaborator

@mcgarrye mcgarrye commented Jul 25, 2024

This PR addresses #(4058)

  • Addresses the issue in full
  • Addresses only certain aspects of the issue

Description

Releases lottery expiration work: bloom-housing#4184

How Can This Be Tested/Reviewed?

Setup: add LOTTERY_DAYS_TILL_EXPIRY=45 to your api and partners env files

Sign into Partners Portal and close a listing with a lottery
As an admin, go to the Lottery tab of the closed listing and open the run modal. Verify that expiration statement is present at the top. Run the lottery, releasedToPartners.
As a partner or jurisdictional admin, go to the Lottery tab of the closed listing with a released lottery. Publish the lottery. Verify yellow warning is present at the top of the section with the expiration date included.
In the database, edit the closedAt date on the listing to 45 (or more) days ago. Or change your env variable to 0.
Sign into the Swagger UI page as an admin or jurisdictional admin. Trigger the cron job with the listings/expireLotteries endpoint.
Sign into the Partners Portal as a partner or jurisdictional admin, go to the Lottery tab of the closed listing with a ran lottery. Verify lottery is expired and no data is shown.

Author Checklist:

  • Added QA notes to the issue with applicable URLs
  • Reviewed in a desktop view
  • Reviewed in a mobile view
  • Reviewed considering accessibility
  • Added tests covering the changes
  • Made corresponding changes to the documentation
  • Ran yarn generate:client and/or created a migration when required

Review Process:

  • Read and understand the issue
  • Ensure the author has added QA notes
  • Review the code itself from a style point of view
  • Pull the changes down locally and test that the acceptance criteria is met
  • Either (1) explicitly ask a clarifying question, (2) request changes, or (3) approve the PR, even if there are very small remaining changes, if you don't need to re-review after the updates

* feat: expire lottery cron job

4058

* feat: frontend expiration

* feat: switch to hero icon

* feat: turning red

* feat: permission tests

* feat: listing e2e tests

* feat: circleci env var

* feat: listings unit test

* Revert "feat: circleci env var"

This reverts commit 37606fe.

* feat: partners unit tests

* feat: minor cleanup changes

* feat: correct env var call

* feat: back to yellow

* feat: remove duplicate styling

* feat: pass backend env var

* feat: omit from listing update

* feat: one more omit

* Revert "feat: one more omit"

This reverts commit 65018aa.

* Revert "feat: omit from listing update"

This reverts commit 6834e44.

* Revert "feat: pass backend env var"

This reverts commit 4fb3cfb.

* feat: add partners env var

* feat: flip exclamation

* feat: changes per morgan

* feat: changes to align with new fe work

* feat: add env var to tests

* feat: show only when published

* feat: merge conflict fix

* feat: minor changes
@mcgarrye mcgarrye added release A PR that is pulling over a commit(s) from core 1 review needed labels Jul 25, 2024
@mcgarrye mcgarrye closed this Jul 25, 2024
@mcgarrye mcgarrye deleted the release/lottery-expiration branch July 25, 2024 17:03
@mcgarrye mcgarrye removed 1 review needed release A PR that is pulling over a commit(s) from core labels Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant