Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

api/google/ and gitignore #108

Closed
andre2007 opened this issue Dec 16, 2017 · 3 comments
Closed

api/google/ and gitignore #108

andre2007 opened this issue Dec 16, 2017 · 3 comments

Comments

@andre2007
Copy link
Contributor

With commit 5b23349 the makefile was enhanced to clone the google apis. These files will be visible in git status. Is there an entry in gitignore missing?
@metrue
Copy link
Owner

metrue commented Dec 16, 2017

@andre2007

Yeah, should put them into .gitignore, will do it soon.

@metrue
Copy link
Owner

metrue commented Dec 16, 2017

fixed by 7c6a224

thanks @andre2007 .

@metrue metrue closed this as completed Dec 16, 2017
@muka
Copy link
Collaborator

muka commented Dec 16, 2017

We may also avoid to copy the files to api and instead add to gen.sh an additional -I pointing to the vendor directory

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@metrue @muka @andre2007