Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recode NONMEM-based model in internal model library #1069

Merged
merged 2 commits into from
Mar 30, 2023
Merged

Recode NONMEM-based model in internal model library #1069

merged 2 commits into from
Mar 30, 2023

Conversation

kylebaron
Copy link
Collaborator

@kylebaron kylebaron commented Mar 27, 2023 •
edited
Loading

Summary

Recoding this model so that it uses the traditional model specification syntax.

timwaterhouse
timwaterhouse reviewed Mar 29, 2023
View reviewed changes
Copy link

@timwaterhouse timwaterhouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I'm just a bit confused by your comment about this model being coded in nm-like. Seems like nm-like is a completely different model?

@kylebaron
Copy link
Collaborator Author

Thanks; you're right it is a different model. I had that tangled up in my head.

@kylebaron kylebaron merged commit 868bb59 into main Mar 30, 2023
@kylebaron kylebaron self-assigned this Jul 15, 2023
@kylebaron kylebaron added this to the v1.1.0 milestone Jul 15, 2023
@kylebaron kylebaron mentioned this pull request Aug 14, 2023
Merged
@kylebaron kylebaron deleted the recode/1005 branch December 14, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timwaterhouse timwaterhouse timwaterhouse left review comments

Assignees

@kylebaron kylebaron

Labels
refactor
Projects
None yet
Milestone
v1.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@kylebaron @timwaterhouse