Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/mtimehx #1119

Merged
merged 4 commits into from
Nov 30, 2023
Merged

Refactor/mtimehx #1119

merged 4 commits into from
Nov 30, 2023

Conversation

kylebaron
Copy link
Collaborator

@kylebaron kylebaron commented Sep 30, 2023

Summary

The evdata object is a way to shuttle new dosing information from the model back to the mrgsolve simulation sequence.

We are adding a check_unique attribute that allows users to skip checking the modeled event history. This lets you schedule identical events if needed.

This PR also adds dose amt into the event history check; this allows users to schedule dosing events to the same compartment at the same time but with different dose amounts without tapping that check_unique attribute.

At this point, tests are only focused on the check_equal feature.

Tests are getting added to a special C++ test space; this space will be added to the drone make target so tests will get run with push to drone.

@kylebaron kylebaron linked an issue Nov 4, 2023 that may be closed by this pull request
Base automatically changed from fix/hx-reset to main November 14, 2023 06:15
Copy link
Contributor

@kyleam kyleam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. The new handling fits nicely into the current code.

As with gh-1125, conflict in inst/maintenance/unit-cpp/test-cpp.R is due to new tests here and new tests from gh-1131. Confirmed that make test-cpp passes when all tests from both sides are included.

@kylebaron kylebaron merged commit 2f2fec5 into main Nov 30, 2023
@kylebaron kylebaron deleted the refactor/mtimehx branch November 30, 2023 16:47
@kylebaron kylebaron mentioned this pull request Dec 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mevent history doesn't get cleaned up properly
2 participants