Move user includes to right before $GLOBAL #1125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyleam
approved these changes
Nov 30, 2023
There was a problem hiding this comment.
Looks good to me.
This has a conflict in inst/maintenance/unit-cpp/test-cpp.R, but that is just due to new tests here and new tests from gh-1131. I confirmed that make test-cpp passes when the conflict is resolved by taking the new tests from both sides.
This PR also brings test-unit.R into the drone make target so this code will get exercised when testing in CI.
Nice. Confirmed that I see it in Drone (for example here).
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before move, could write a function in file included by
$INCLUDEthat accepteddataboxtype as an argument.Rationale for the new location: code in
$INCLUDEis just user-written code that would otherwise go in$GLOBAL; so it should be reasonable to include it at that point.This PR also brings
test-unit.Rinto thedronemake target so this code will get exercised when testing in CI.See #1126