-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/infusion now #1131
Merged
Merged
Fix/infusion now #1131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyleam
approved these changes
Nov 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the summary and details. Some of devtran.cpp
changes are a bit beyond my grasp but overall look good to me.
I confirmed that make test-cpp
passes on this PR and fails as expected when I revert the code changes.
This was referenced Nov 30, 2023
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Users are allowed to trigger discontinuities in the simulation (e.g. doses) from within the model. This is done through an
evdata
object which can be scheduled at some time in the future or the user can ask for it to happennow
.There was a bug in this when an infusion was given by this now mechanism: there was no code to turn the infusion off.
As I was addressing this issue, I realized that there are some other expected behaviors for these doses that weren't getting implemented when these
now
doses were triggered.Details
Workflow
test-cpp.R
devtran.cpp
prob.rate_main()
can be called regardless of whether the record just came from the data or not; whenever therate
attribute is non-negative, this call will do nothing; added logic inrate_main()
to make this clearevid
is0
; this is an observationnew_ev
) we have to process it like other event records; get and check the bioavailability, callrate_main()
, etcodeproblem.cpp
rate
is not negative