Fix behavior for regimen::ii() #1170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1169 for details. This PR changes
regimen::ii()to just just update the dose interval, with no other fancy tricks. Look at the working example in #1169; I think that's what we want.I put a note in the tests that I took the cutoffs for those tests from looking at a plot of the profile. The plot looks right to me. The tests check that the pattern we get is what we'd expect from the model code. But the exact cutoffs aren't obvious.
@kyleam I'd like to send this through as a hotfix if possible. As for general reliability, I've been kicking the tires for several hours on this working up a blog post and no other surprises found.