This repository has been archived by the owner on Jun 9, 2024. It is now read-only.
Provide better shard management abstractions #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe add an option to start specific shard ids (from an array/list), or at least a range? |
|
This is on the list to add |
queer
changed the title
queer
changed the title
queer
changed the title
|
seems 👌 |
|
Okay this is probably good so let's merge it and see what happens 👏 |
|
Well look at that, it doesn't work 🎉 |
|
It works now 🎉 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not ready to merge this, just gonna open it for @natanbc @SamOphis @gabixdev to give feedback on.
Fixes #85