New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rgb/rgba and hsl/hsla advanced syntax options #37

Closed

7 tasks done

meyfa opened this issue Dec 30, 2017 · 1 comment

Closed

7 tasks done

rgb/rgba and hsl/hsla advanced syntax options #37

meyfa opened this issue Dec 30, 2017 · 1 comment

Labels

Owner

meyfa commented Dec 30, 2017 •

edited

Loading

According to MDN [1], there are quite a few more ways to specify colors than are currently covered by the SVG::parseColor method.

The following notations in particular would need to be handled:

#RRGGBBAA (hexadecimal notation with alpha component)
#RGBA (short hex notation with alpha component)
rgb(255, 255, 255, 50%) (note the percentage used for alpha)
rgb(255 255 255) (note the missing commas)
rgb(255 255 255 / 50%) and rgb(255 255 255 / .5) (note the slash)
hsl with different units
hsl with alpha given as percentage

Keep in mind that as per #36, everything mentioned above for rgb also applies to rgba, and everything mentioned for hsl also applies to hsla.

[1] https://developer.mozilla.org/en-US/docs/Web/CSS/color_value

The text was updated successfully, but these errors were encountered:

meyfa added the enhancement label

Owner Author

meyfa commented Jan 5, 2018

Fixed in 203c93e.

meyfa closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment