Fix unit tests and retrieve namespace from XML response #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! I'm going to try to find some time to test and hopefully incorporate these changes this week. |
|
@smeegoan Can you remove the namespace changes and just leave the test fixes in this PR? |
This reverts commit 81fdf13.
|
done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I updated my Hikvision NVR firmware and now the XML response namespace is different http://www.isapi.org/ver20/XMLSchema instead of http://www.hikvision.com/ver20/XMLSchema
My changes fix the unit tests and retrieve the XML namespace from the response.