Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added PHP 8.0 support #4 #5

Merged
merged 1 commit into from
Nov 18, 2020
Merged

Conversation

svycka
Copy link
Contributor

@svycka svycka commented Nov 4, 2020

Q A
New Feature yes

Summary
To be prepared for the december release of PHP 8.0, this repository has some additional TODOs to be tested against the new major version.

In order to make this repository compatible, one has to follow these steps:

  • Modify composer.json to provide support for PHP 8.0 by adding the constraint ~8.0.0
  • Modify composer.json to drop support for PHP less than 7.3
  • Modify composer.json to implement phpunit 9.3 which supports PHP 7.3+
  • Modify .travis.yml to ignore platform requirements when installing composer dependencies (simply add --ignore-platform-reqs to COMPOSER_ARGS env variable)
  • Modify .travis.yml to add PHP 8.0 to the matrix (NOTE: Do not allow failures as PHP 8.0 has a feature freeze since 2020-08-04!)
  • Modify source code in case there are incompatibilities with PHP 8.0

closes #4

@svycka svycka marked this pull request as ready for review November 4, 2020 13:05
@froschdesign froschdesign added the Enhancement New feature or request label Nov 4, 2020
@froschdesign froschdesign added this to the 5.4.0 milestone Nov 4, 2020
Copy link
Member

@froschdesign froschdesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! 👍

This is a first review with some small hints.

.travis.yml Outdated Show resolved Hide resolved
.travis.yml Show resolved Hide resolved
.travis.yml Show resolved Hide resolved
phpunit.xml.dist Outdated Show resolved Hide resolved
Signed-off-by: Vytautas Stankus <svycka@gmail.com>
Copy link
Member

@boesing boesing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@boesing boesing merged commit 9a96124 into mezzio:5.4.x Nov 18, 2020
@boesing
Copy link
Member

boesing commented Nov 18, 2020

Thanks, @svycka!

@svycka svycka deleted the feature-4/php8.0-support branch November 18, 2020 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PHP 8.0 support
4 participants