Plugin system #28
Plugin system #28
Conversation
amarillo/services/secrets.py
Outdated
| @@ -1,10 +1,13 @@ | |||
| from typing import Dict | |||
| from pydantic import Field | |||
| from pydantic_settings import BaseSettings | |||
|
|
|||
| from typing import Optional | |||
There was a problem hiding this comment.
could you just add this to the already existing import in line 1 (or inversely add Dict from line 1)?
amarillo/services/secrets.py
Outdated
| # TODO: define these as required if metrics plugin is installed | ||
| metrics_user: Optional[str] = Field(None, env = 'METRICS_USER') | ||
| metrics_password: Optional[str] = Field(None, env = 'METRICS_PASSWORD') |
There was a problem hiding this comment.
It feels a bit strange to have plugin configuration in the core settings. Shouldn't this be done by the plugins requiring additional config?
There was a problem hiding this comment.
I agree, I'll try and find a way to have this configuration on the plugin side
| "fastapi[all]==0.109.0", | ||
| "geopandas==0.14", | ||
| "uvicorn[standard]==0.23.2", | ||
| "pydantic[dotenv]==2.4.2", | ||
| "protobuf==3.20.3", | ||
| "starlette~=0.35", | ||
| "requests==2.31.0", | ||
| "pyproj==3.6.1", | ||
| "geojson-pydantic==1.0.1", | ||
| "watchdog==3.0.0", |
There was a problem hiding this comment.
I guess version pinning in requirements.txt and requirements-dev.txt should be sufficient, or why do we need to duplicate it here?
There was a problem hiding this comment.
requirements.txt does not get included in the python package, it is not considered when the package is pip installed.
|
Rebase on new plugins branch |
frsaba
force-pushed
the
plugins-migration-metrics
branch
from
ee0f3ab
to
ce7539b
Compare
frsaba
force-pushed
the
plugins-migration-metrics
branch
from
f9142c3
to
c0d4263
Compare
Made Amarillo into a python package and created a plugin system based on https://packaging.python.org/guides/creating-and-discovering-plugins/. Plugins are discovered dynamically from python packages placed under the amarillo/plugins namespace. A plugin can define a
setupfunction that receives the FastAPI app object as a parameter.