This repository has been archived by the owner on Sep 7, 2024. It is now read-only.
Improve numeric_send and handle decimal scale correctly #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes truncation of DECIMAL/NUMERIC numbers.
For example the numeric '50.34' in the db would be returned as '50.3400'. A test for this has been added.
mfenniak
added a commit
that referenced
this pull request
Jun 19, 2013
Merge PR to improve numeric_send and handle scale on decimal objects property
|
Thanks for sending the PR, Tony. I've merged the changes. Would you be interested in being added as a collaborator to the project, with full repository access? I've been looking for people who might be interested in helping with the maintenance of this software. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Mathieu, I came across a bug in pg8000 where for example the numeric '50.34' in the db would be returned as '50.3400'. I think I've worked out what's going on, and this pull request should fix it. I've added a test for the bug. Let me know if there are any changes you'd like me to make.
Cheers,
Tony.