Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AlarmManager._event_match() only consider the first triggering events of the alarm #83

Closed
tristanlatr opened this issue Oct 3, 2020 · 0 comments
Closed

AlarmManager._event_match() only consider the first triggering events of the alarm #83

tristanlatr opened this issue Oct 3, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@tristanlatr
Copy link
Contributor

tristanlatr commented Oct 3, 2020 •
edited
Loading

Describe
When using AlarmManager, only the first event is compared against events filters.

msiempy/msiempy/alarm.py

Line 351 in ad5c754

value = str(alarm["events"][0][event_filter[0]])

Expected behaviour would consider the filter matching if any triggering event match all passed filters.

msiempy version:
msiempy : 0.3.3
@tristanlatr tristanlatr added the enhancement New feature or request label Oct 3, 2020
tristanlatr added a commit that referenced this issue Oct 4, 2020
@tristanlatr
Feature #83
3bbef5b 
Consider the AlarmManager events filter matching if any triggering event match all passed filters

Implement a couple tests
tristanlatr added a commit that referenced this issue Oct 5, 2020
@tristanlatr
Add another test for #83
ec203c0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tristanlatr