Initial tvOS support #114
Closed
Initial tvOS support #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I turns out that the code used to produce the script file URL behaves differently on OS X compared to iOS. This commit resorts to simply prepending the path with "file:///"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please test!
I don't think I introduced any regressions (tried on both iOS and tvOS targets after making the changes), but xcodeproj files are a bear, so please let me know if I accidentally tweaked something that causes the file to no longer open in an older version of Xcode that you're interested in continuing to support.
GCDWebServer v3.3 landed about a week ago, noticed on Monday, and finally got around to building the demo app target for tvOS.
Reusing the same AppDelegate source code from the original demo app.
Thanks,
Ethan