-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
initial tvos support and demo app target #115
Conversation
Another error I get when attempting to run the Ambly Demo TV target is an inability to link to the Ambly pod, it appears:
|
Eek, dunno how Info-TV.plist got lost in the fray. Will try to resubmit first thing tomorrow. |
- add missing assets (Info-TV and images)
Heh, okay, the missing assets are in. I guess I just got trigger-happy yesterday and completely neglected to add the new files to the commit. |
As far as the linker error, if you ever encounter that again, I think a fresh |
@sherbondy The What I'm doing is getting the patch from this PR (via https://github.com/omcljs/ambly/pull/115.patch) and applying it to a fresh clone, and trying it out. The iOS demo app links and runs but not the tvOS demo app. |
ED387D171A602B56007E40A2 /* Resources */ = { | ||
isa = PBXResourcesBuildPhase; | ||
buildActionMask = 2147483647; | ||
files = ( | ||
ED387D281A602B56007E40A2 /* Main.storyboard in Resources */, | ||
ED387D2D1A602B56007E40A2 /* LaunchScreen.xib in Resources */, | ||
AA64223D1C28A8E5002F7170 /* Info-TV.plist in Resources */, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Info-TV.plist
is listed under Build Phases > Copy Bundle Resources for the Ambly Demo target (the non-tvOS target). I bet it causes no issue but is also probably caused by this line here.
I think the root problem with the linking has to do with the target specifiers in the Podfile. If remove the conditional blocks simply specify Also, I'm seeing that discovery doesn't work until I restart the app (happens to iOS and tvOS), which may be related to GCDWebServer 3.3. Given this funkiness, I've put your patch in a tvos branch were these subtle issues can be ironed out before fully merging in, but where people can also try things. Your patch is in here c7caf85 I'll close this PR manually. |
(Resubmitting with history squashed into single commit)
Please test!
I don't think I introduced any regressions (tried on both iOS and tvOS targets after making the changes), but xcodeproj files are a bear, so please let me know if I accidentally tweaked something that causes the file to no longer open in an older version of Xcode that you're interested in continuing to support.
GCDWebServer v3.3 landed about a week ago, noticed on Monday, and finally got around to building the demo app target for tvOS.
Reusing the same AppDelegate source code from the original demo app.
Thanks,
Ethan