Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid contains? in -contains-key? #79

Closed
mfikes opened this issue Apr 25, 2021 · 0 comments · Fixed by #80
Closed

Avoid contains? in -contains-key? #79

mfikes opened this issue Apr 25, 2021 · 0 comments · Fixed by #80

Comments

@mfikes
Copy link
Owner

mfikes commented Apr 25, 2021

The Bean type implements IAssociative -contains-key? by simply calling contains?

With CLJS-3283, contains? is being revised to first check if a type implements IAssociative and then directly calls -contains-key?

This causes infinite recursion with Bean implementation.
mfikes added a commit that referenced this issue Apr 25, 2021
@mfikes
Avoid contains? in -contains-key?
e9b161a 
Fixes #79
@mfikes mfikes mentioned this issue Apr 25, 2021
Merged
mfikes added a commit that referenced this issue Apr 25, 2021
@mfikes
Avoid contains? in -contains-key? (#80)
2a794b6 
Fixes #79
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Avoid contains? in -contains-key? mfikes/cljs-bean
1 participant
@mfikes